ES|QL: make telemetry more strict #126940
Merged
+86
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luigidellaquila
added
auto-backport
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
@bpintea when we implemented This PR is mainly to avoid that we forget it again |
luigidellaquila
added a commit
to luigidellaquila/elasticsearch
that referenced
this pull request
Apr 17, 2025
This was referenced Apr 17, 2025
luigidellaquila
added a commit
to luigidellaquila/elasticsearch
that referenced
this pull request
Apr 17, 2025
luigidellaquila
added a commit
to luigidellaquila/elasticsearch
that referenced
this pull request
Apr 17, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 17, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 17, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding new commands, it's easy to miss the fact that they have to be added to the telemetry (phone-home).
This PR adds an explicit check so that a command has to be mapped or explicitly excluded, otherwise we'll throw an exception.
This also maps missing commands (LOOKUP JOIN, CHANGE POINT, INLINESTATS, RERANK, DEDUP, INSIST, FORK, RRF, COMPLETION)
TODO:
60_usage.yml